Merged
Conversation
Contributor
zachmargolis
commented
Oct 14, 2021
zachmargolis
commented
- Hopefully to fix "unknown relation good_jobs" error
- Hopefully to fix "unknown relation good_jobs" error
zachmargolis
requested review from
aduth,
jmdembe,
mdiarra3,
mitchellhenke and
stevegsa
zachmargolis
commented
Oct 14, 2021
Comment on lines
-10
to
-12
| # Configure GoodJob even if it's not enabled, to avoid errors if the good_job process is started, | ||
| # such as in local development. | ||
| GoodJob.active_record_parent_class = 'WorkerJobApplicationRecord' |
Contributor
Author
There was a problem hiding this comment.
working hypothesis: this initializer is "too late" for this config to be set, it's the one we need for the jobs to look in the right database
aduth
approved these changes
Oct 15, 2021
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Unfortunately I could no longer reproduce the original issue on main before trying this branch, but the hypothesis seems sensible enough to me 👍
mitchellhenke
approved these changes
Oct 15, 2021
zachmargolis
commented
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.