Do not log PII when verifying personal key#5431
Merged
mitchellhenke merged 1 commit intomainfrom Sep 21, 2021
Merged
Conversation
mitchellhenke
requested review from
aduth,
akrito,
jmhooper and
zachmargolis
jmhooper
approved these changes
Sep 21, 2021
mitchellhenke
force-pushed
the
mitchellhenke/avoid-logging-pii
branch
from
017ed67 to
db41758
Compare
aduth
approved these changes
Sep 21, 2021
| analytics_result = FormResponse.new( | ||
| success: result.success?, | ||
| errors: result.errors, | ||
| extra: result.extra.except(:decrypted_pii), |
Contributor
There was a problem hiding this comment.
This would always be empty (as of today), so we could just omit extra altogether.
mitchellhenke
pushed a commit
that referenced
this pull request
Sep 21, 2021
zachmargolis
added a commit
that referenced
this pull request
Oct 14, 2021
zachmargolis
added a commit
that referenced
this pull request
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.