Skip to content

Remove scan ID doc auth demo#3825

Merged
jmhooper merged 4 commits intomasterfrom
jmhooper-remove-doc-auth-v2
Jun 9, 2020
Merged

Remove scan ID doc auth demo#3825
jmhooper merged 4 commits intomasterfrom
jmhooper-remove-doc-auth-v2

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Jun 9, 2020

Why: We have moved this functionality into the doc auth flow.

**Why**: We have moved this functionality into the mainline doc auth flow.
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible! So much red!!!! One comment about more we can remove but otherwise LGTM!

get '/verify/doc_auth_v2/link_sent/poll' => 'idv/doc_auth_v2#doc_capture_poll'
get '/verify/doc-auth-v2/:step' => 'idv/doc_auth_v2#show',
# sometimes underscores get messed up when linked to via SMS
as: :idv_doc_auth_v2_step_dashes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this URL is referenced in the send_link_step so I think we can remove it from there now

@jmhooper jmhooper merged commit 3b1772c into master Jun 9, 2020
@jmhooper jmhooper deleted the jmhooper-remove-doc-auth-v2 branch June 9, 2020 18:23
aduth added a commit that referenced this pull request Oct 14, 2021
**Why**: Because it's no longer used. It was added in #6 as part of CodeClimate checks, which was later removed in #3825.
aduth added a commit that referenced this pull request Oct 15, 2021
**Why**: Because it's no longer used. It was added in #6 as part of CodeClimate checks, which was later removed in #3825.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants