Merged
Conversation
aduth
reviewed
Oct 1, 2021
mdiarra3
added
javascript
aduth
reviewed
Oct 5, 2021
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Looks like there's a failing test that needs to be updated. Are we still expecting the notice banner to be visible with the JavaScript validation? If not, we could update the test to look for the field message instead for when JavaScript is enabled?
aduth
reviewed
Oct 8, 2021
aduth
added a commit
that referenced
this pull request
Nov 23, 2021
**Why**: It is now handled by adjacent inline text element as of #5468
aduth
added a commit
that referenced
this pull request
Nov 23, 2021
* Form Validation: Limit custom validation reset to own validation **Why**: To avoid conflicts between form-validation custom validation and other custom validation which may apply to an input (e.g. a component implementation). * Render phone forms as validated form **Why**: Consistency of form rendering and validation (e.g. required field messaging) * Remove unused SSN pattern type matching **Why**: It is now handled by adjacent inline text element as of #5468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Current way that we implement this we leverage the default tooltip for users. This will allow the errors to be listed properly for required inputs directly below.