Merged
Conversation
LexisNexis informed us that the name suffix should be available in a TrueID response if the name suffix is present on the document. This commit adds the name suffix to the response fixture so that we have a fixture to represent this case. We plan to read the name suffix and check it against the DLDV service in a future change. This commit prepares us for that. [skip changelog]
In #11534 we identified that this file was not properly formatted. This commit updates the contents of the file to be formatted using `jq`. [skip changelog]
* changelog: Internal, Facial Match, Clean up config post-GA
…11527) Proofing components are intended to represent the tooling that was used to create a profile. Traditionally these have been generated by tracking proofing components in a database table associated with the user. There were a number of problems with this approach which 5021e2e introduced a `Idv::ProofingComponents` service to address. This service generates proofing components from the session instead of from the database table. This commit uses the `Idv::ProofingComponents` service to generate the proofing components stored on the profile. This will allow us to drop the proofing components table in a future change. [skip changelog]
* LG-15125: Wait for Socure result - hybrid flow As in #11500 for the standard flow, we need to wait for the Socure result to be received before we can determine where to send the user. Currently, if the wait times out, we show a placeholder plain text of "Technical difficulties!!!" to be replaced with the appropriate "Try again?" page in a following ticket. Note there is some identical code in the standard vs hybrid controllers that might be refactored into a concern in the future, but until all of the paths are complete, I thought it best to live with the duplication for now. [skip changelog]
changelog: Internal, Analytics, Document analytics event parameters
changelog: Internal, Analytics, Document analytics event parameters
…ent (#11457) * Revert "Log if password matches current for password reset event (#11423)" This reverts commit a419d8c. * Remove inaccurate route verb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Refactor form specs for updated expectations * Remove spec expectations for password_matches_existing --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* helper to send webhooks during feature testing * init socure feature test * remove unused functions and working happy path * rebase - merege conflict resolved * rebase - merege conflict resolved * make stub_docv_document_request dynamic * spec for re-routing lost socure hybrid flow user * move socure doc auth test helprs to to doc cap step helper * add feature spec for socure hybrid mobile * socure hybrid mobile w/o allow_net_connect_on_start * fix specs * remove unused code and allow mock requests * [skip changelog] * remove commented lines * send all docv webhook endpoints when uploading documents * happy linting * happy linting take 2 * remove uneeded before block statement * use new renamed socure env vars * use new renamed socure env vars socure_docv_document_request_endpoint * alphabetized socure_docv_document_request_endpoint in yaml config
* Remove proofer_mock_fallback fallback Remove support for the proofer_mock_fallback setting when creating resolution proofers. [skip changelog] * Update ResolutionProofingJob spec Tell it to use the Instant Verify proofer for its tests. * tonight my autoformatter let me down
* Remove proofer_mock_fallback fallback Remove support for the proofer_mock_fallback setting when creating resolution proofers. [skip changelog] * Update ResolutionProofingJob spec Tell it to use the Instant Verify proofer for its tests. * tonight my autoformatter let me down * Add null safe navigation operator to ResolutionProofingJob If an exception happens earlier in the job, then document_capture_session can be nil here. Previously this would raise a NoMethodError, obscuring the root cause. * Rename instant_verify_state_address_result More generic, now state_address_resolution_result * Rename instant_verify_residential_address_result Go with more generic residential_address_resolution_result * RequestError -> Request::Error There were some autoloading issues in cases where calling code wants access to the Error class but does not load the Request class first * Don't crash when applicant includes extra fields In practice, applicant will have extra fields like `state_id_jurisdiction`, `state_id_number`, etc. * Allow identity resolution via Socure Update the ProgressiveProofer to be able to use Socure KYC. changelog: Upcoming Features, Identity verification, Support Socure for identity resolution. * Remove irrelevant tests * you don't have to say with_aamva everybody knows its aamva
changelog: Internal, Documentation, Document usage of Lookbook for ViewComponents
* Upgrade DAP to v8.4 release changelog: Internal, Analytics, Upgrade Digital Analytics Program to v8.4 release * Try fixing patch
* Add unlimited preload headers for style, script assets changelog: Internal, Performance, Add preload headers for all style, script assets * Update spec assertions for dropped whitespace * Add specs * Append with string mutation See: https://github.com/18F/identity-idp/pull/11504/files#r1841273216 Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Use plain tag helper for generating script tag We don't need any of this anymore: - Asset pipeline lookup - Preload headers handling - Server push - Multiple source concatenation - Nonce handling crossorigin as a boolean attribute is same as crossorigin=anonymous * Add spec for preload_links_header attribute handling * Evaluate crossorigin once Previously evaluated per script, even though the result would always be the same * Micro-optimize append * Lowercase header key * Use presence to toggle between true/nil * Sync specs to use lowercase link key --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…igurable depth (#11541) * Update Data Request script to compute requesting issuer and have configurable depth changelog: Internal, Scripts, Update DataRequest script to compute requesting issuer and have configurable depth * add log for multiple service providers * Update lib/data_pull.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update lib/data_pull.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
changelog: Internal, A/B Tests, Fix logging for A/B test to recommend platform authenticator to SMS users
…r report (#11553) changelog: Internal, Reporting, Do not return User UUID in requesting_issuer_uuid when generating user report
changelog: Bug Fixes, In-person proofing, fixes redirect for put for state id routes renaming
* changelog: Internal, Analytics, Add tracking for sha256 change
* LG-15119 Update MKMR to split verified users by facial matching changelog: Internal, Reporting, Update MKMR to split verified useres by facial matching
Will have no effect unless `high_socure_docv` is added to the config `good_job_queues` [skip changelog]
…ent (#11558) changelog: Internal, Logging, Log requesting signing and certificate serial in SAML Auth Request event
jmhooper
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal