Log requesting signing and certificate serial in SAML Auth Request event#11558
Merged
mitchellhenke merged 1 commit intomainfrom Nov 26, 2024
Conversation
changelog: Internal, Logging, Log requesting signing and certificate serial in SAML Auth Request event
Sgtpluck
approved these changes
Nov 26, 2024
mitchellhenke
deleted the
mitchellhenke/log-signed-and-cert-certial-for-saml-request-analytics
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This PR adds additional attributes to the SAML requests we receive. They are currently also logged on the
SAML Authevent, which is only logged on successful authentication. It would be useful to also have these when the request is received even if the user does not authenticate.