LG-14725: Identity resolution via Socure#11523
Merged
Conversation
n1zyy
approved these changes
Nov 19, 2024
Contributor
|
I approved this but didn't look at the test results. It seems one of them possibly went into an infinite loop? 😱 |
Remove support for the proofer_mock_fallback setting when creating resolution proofers. [skip changelog]
Tell it to use the Instant Verify proofer for its tests.
da282e7 to
5d0de74
Compare
b52398c to
5242f29
Compare
If an exception happens earlier in the job, then document_capture_session can be nil here. Previously this would raise a NoMethodError, obscuring the root cause.
More generic, now state_address_resolution_result
Go with more generic residential_address_resolution_result
There were some autoloading issues in cases where calling code wants access to the Error class but does not load the Request class first
In practice, applicant will have extra fields like `state_id_jurisdiction`, `state_id_number`, etc.
Update the ProgressiveProofer to be able to use Socure KYC. changelog: Upcoming Features, Identity verification, Support Socure for identity resolution.
5242f29 to
d5eb021
Compare
lmgeorge
approved these changes
Nov 20, 2024
Contributor
lmgeorge
left a comment
There was a problem hiding this comment.
Overall, looks suspiciously familiar and good!
jmhooper
approved these changes
Nov 20, 2024
Base automatically changed from
matthinz/config-for-resolution-proofer-cleanup
to
main
November 22, 2024 00:48
everybody knows its aamva
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is a do-over of #11479, with the
proofer_mock_fallbackstuff taken out. It's based on #11516, which will need to land first.)🎫 Ticket
Link to the relevant ticket:
LG-14725
🛠 Summary of changes
This PR adds provisional support for using Socure KYC for identity resolution. To do this, it:
instant_verify_state_id_address_resultbecomesstate_id_address_result)idv_resolution_alternate_vendorandidv_resolution_alternate_vendor_percentsettings to configure what % of transactions go to Socure.if proofing_vendor == :socure_kyc-type code to create the correct proofer based on the configured vendorNew configuration flags
This PR adds two new config flags:
idv_resolution_alternate_vendornoneidv_resolution_alternate_vendor_percent0idv_resolution_alternate_vendorcan be set to one of:mockinstant_verifysocure_kycIf
idv_resolution_alternate_vendor_percentis greater than zero, then that percentage of resolutions will use the alternate vendor. Note that whichever vendor is selected is used for both state ID and residential address transactions associated with a single run of the ResolutionProofingJobs--subsequent jobs will flip the coin again.📜 Testing Plan
First, configure Socure in your
application.yml:Next, send all of your resolutions to Socure:
Now, run through IdV. Check your
log/events.logfile and verify that your most recentIdV: doc auth verify proofing resultsevent uses the vendorsocure_kyc.Now, send all your resolutions to the mock proofer:
Run through IdV and verify that your most recent
IdV: doc auth verify proofing resultsevent uses the vendormock.