LG-14366 Store dynamically-generated proofing components on Profile#11527
Merged
LG-14366 Store dynamically-generated proofing components on Profile#11527
Conversation
Proofing components are intended to represent the tooling that was used to create a profile. Traditionally these have been generated by tracking proofing components in a database table associated with the user. There were a number of problems with this approach which 5021e2e introduced a `Idv::ProofingComponents` service to address. This service generates proofing components from the session instead of from the database table. This commit uses the `Idv::ProofingComponents` service to generate the proofing components stored on the profile. This will allow us to drop the proofing components table in a future change. [skip changelog]
n1zyy
approved these changes
Nov 20, 2024
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
This ends up looking pretty straightforward.
lmgeorge
approved these changes
Nov 20, 2024
Contributor
lmgeorge
left a comment
lmgeorge
left a comment
There was a problem hiding this comment.
A couple of non-blocking things, but otherwise approved!
lmgeorge
reviewed
Nov 20, 2024
| password, | ||
| resolved_authn_context_result.enhanced_ipp?, | ||
| is_enhanced_ipp: resolved_authn_context_result.enhanced_ipp?, | ||
| proofing_components: ProofingComponents.new( |
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): Extract ProofingComponents creation to a private method.
(failed to submit with the review, adding now)
jmhooper
deleted the
jmhooper-dynamically-generated-proofing-components
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proofing components are intended to represent the proofing flow that was used to create a profile. Traditionally these have been generated by tracking proofing components in a database table associated with the user. There were a number of problems with this approach which 5021e2e introduced a
Idv::ProofingComponentsservice to address. This service generates proofing components from the session instead of from the database table.This commit uses the
Idv::ProofingComponentsservice to generate the proofing components stored on the profile. This will allow us to drop the proofing components table in a future change.