Revert logging whether password matches current for password reset event#11457
Merged
Revert logging whether password matches current for password reset event#11457
Conversation
zachmargolis
approved these changes
Nov 6, 2024
)" This reverts commit a419d8c.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
force-pushed
the
aduth-revert-password-matches-existing
branch
from
683b7d9 to
73d5111
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Effectively reverts #11423.
This pull request is created preemptively under the assumption that the test will only run for a short amount of time to collect enough data to build a case, not because there are any specific problems with the code itself.
This keeps refactoring improvements in #11423. The specific process for reverting was:
git revert a419d8c(a419d8c)git cherry-pick ba76ff4(ba76ff4)git cherry-pick 23e93e1(23e93e1)password_matches_existingextra property fromResetPasswordFormspec (683b7d9de7c25564d8286a4ad5aaa994816f87b5)(This is reflected in branch commit history)
📜 Testing Plan
Repeat testing plan from #11423, verifying that there is no
password_matches_existingin the password reset event payload.