LG-14007: wait for Socure result if not present upon return#11500
Merged
LG-14007: wait for Socure result if not present upon return#11500
Conversation
amirbey
reviewed
Nov 13, 2024
Comment on lines
70
to
74
Contributor
There was a problem hiding this comment.
thanks for adding logic to handle this async result fetching. a timeout could be helpful here 🤔 as it seems like the user is stuck in a loop here until the result is fetched. also, we should seek feedback for UX and also create the possibility for a back button which would create an exit path here.
solipet
force-pushed
the
dprice/lg-14007-wait-for-result
branch
2 times, most recently
from
ba9e50e to
18f8cd2
Compare
…ntroller Spoke with Team Joy and the issue this was addressing is OBE
If the user returns from Socure before the job has finished fetching the results, wait and check every 15 seconds. [skip changelog]
solipet
force-pushed
the
dprice/lg-14007-wait-for-result
branch
from
18f8cd2 to
0311e65
Compare
sleep on the job new defaults
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
solipet
added a commit
that referenced
this pull request
Nov 20, 2024
As in #11500 for the standard flow, we need to wait for the Socure result to be received before we can determine where to send the user. Currently, if the wait times out, we show a placeholder plain text of "Technical difficulties!!!" to be replaced with the appropriate "Try again?" page in a following ticket. Note there is some identical code in the standard vs hybrid controllers that might be refactored into a concern in the future, but until all of the paths are complete, I thought it best to live with the duplication for now. [skip changelog]
solipet
added a commit
that referenced
this pull request
Nov 20, 2024
* LG-15125: Wait for Socure result - hybrid flow As in #11500 for the standard flow, we need to wait for the Socure result to be received before we can determine where to send the user. Currently, if the wait times out, we show a placeholder plain text of "Technical difficulties!!!" to be replaced with the appropriate "Try again?" page in a following ticket. Note there is some identical code in the standard vs hybrid controllers that might be refactored into a concern in the future, but until all of the paths are complete, I thought it best to live with the duplication for now. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14007
🛠 Summary of changes
Upon return from Socure via the redirect url, check for the stored result (fetched by a job triggered by a webhook event). If not yet present, render the wait page that refreshes every 15 secs.