LG-15125: Wait for Socure result - hybrid flow#11530
Merged
Conversation
As in #11500 for the standard flow, we need to wait for the Socure result to be received before we can determine where to send the user. Currently, if the wait times out, we show a placeholder plain text of "Technical difficulties!!!" to be replaced with the appropriate "Try again?" page in a following ticket. Note there is some identical code in the standard vs hybrid controllers that might be refactored into a concern in the future, but until all of the paths are complete, I thought it best to live with the duplication for now. [skip changelog]
solipet
commented
Nov 20, 2024
solipet
commented
Nov 20, 2024
solipet
commented
Nov 20, 2024
solipet
commented
Nov 20, 2024
amirbey
reviewed
Nov 20, 2024
app/controllers/idv/hybrid_mobile/socure/document_capture_controller.rb
Outdated
Show resolved
Hide resolved
amirbey
approved these changes
Nov 20, 2024
solipet
force-pushed
the
dprice/lg-15125-wait-for-socure-hybrid-edition
branch
from
ab76682 to
efc39f6
Compare
solipet
force-pushed
the
dprice/lg-15125-wait-for-socure-hybrid-edition
branch
from
efc39f6 to
28346f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15125
🛠 Summary of changes
As in #11500 for the standard flow, we need to wait for the Socure result to be received before we can determine where to send the user.
Currently, if the wait times out, we show a placeholder plain text of "Technical difficulties!!!" to be replaced with the appropriate "Try again?" page in a following ticket.
Note there is some identical code in the standard vs hybrid controllers that might be refactored into a concern in the future, but until all of the paths are complete, I thought it best to live with the duplication for now.