Skip to content

Document analytics events properties to remove unnecessary allowed_extra_analytics#11536

Merged
aduth merged 1 commit intomainfrom
aduth-rm-allowed-extra-analytics
Nov 21, 2024
Merged

Document analytics events properties to remove unnecessary allowed_extra_analytics#11536
aduth merged 1 commit intomainfrom
aduth-rm-allowed-extra-analytics

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented Nov 20, 2024

🛠 Summary of changes

Documents a handful more analytics methods to remove allowed_extra_analytics, toward eventual eradication of this metadata option.

📜 Testing Plan

Verify build passes.

Spot check that required keyword arguments would be provided in all circumstances.

changelog: Internal, Analytics, Document analytics event parameters
@aduth aduth requested review from a team, jennyverdeyen and solipet and removed request for a team November 20, 2024 20:40
@aduth aduth merged commit 56ba291 into main Nov 21, 2024
@aduth aduth deleted the aduth-rm-allowed-extra-analytics branch November 21, 2024 13:17
Copy link
Copy Markdown
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reprocess_delay_minutes: reprocess_delay_minutes,
enrollments_count:,
reprocess_delay_minutes:,
job_name:,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants