Skip to content

Add name suffix to TrueID response fixture#11534

Merged
jmhooper merged 1 commit intomainfrom
jmhooper-add-name-suffix-to-response-fixture
Nov 20, 2024
Merged

Add name suffix to TrueID response fixture#11534
jmhooper merged 1 commit intomainfrom
jmhooper-add-name-suffix-to-response-fixture

Conversation

@jmhooper
Copy link
Copy Markdown
Contributor

LexisNexis informed us that the name suffix should be available in a TrueID response if the name suffix is present on the document. This commit adds the name suffix to the response fixture so that we have a fixture to represent this case.

We plan to read the name suffix and check it against the DLDV service in a future change. This commit prepares us for that.

LexisNexis informed us that the name suffix should be available in a TrueID response if the name suffix is present on the document. This commit adds the name suffix to the response fixture so that we have a fixture to represent this case.

We plan to read the name suffix and check it against the DLDV service in a future change. This commit prepares us for that.

[skip changelog]
@jmhooper jmhooper requested a review from a team November 20, 2024 17:58
"Name": "Fields_FirstName",
"Values": [{"Value": "LICENSE"}]
},
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird indenting

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm matching the existing pattern which I cannot explain

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe follow-up PR to run that whole thing through jq or JSON.pretty_print

@jmhooper jmhooper merged commit 8ff746f into main Nov 20, 2024
@jmhooper jmhooper deleted the jmhooper-add-name-suffix-to-response-fixture branch November 20, 2024 18:17
jmhooper added a commit that referenced this pull request Nov 20, 2024
In #11534 we identified that this file was not properly formatted. This commit updates the contents of the file to be formatted using `jq`.

[skip changelog]
jmhooper added a commit that referenced this pull request Nov 20, 2024
In #11534 we identified that this file was not properly formatted. This commit updates the contents of the file to be formatted using `jq`.

[skip changelog]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants