Merged
Conversation
**Why**: RISC notifications are delivered through an ActiveJob; inline invocation is no longer used. **How**: 1. Remove references to risc_notifications_active_job_enabled in code and assume it to be true 2. Refactor tests to assert that RiscDeliveryJob is scheduled with the correct arguments changelog: Internal, RISC, Remove obsolete code
changelog: Bug Fixes, Accessibility, Render email language preference as language of parts
* Replace Alert component "other" as default style changelog: Internal, UI Components, Replace Alert component "other" as default style * Shift nil validation to VALID_TYPES See: https://github.com/18F/identity-idp/pull/10779/files#r1631544531
* Standardize form validation for WebauthnSetupForm changelog: Internal, WebAuthn, Standardize form validation for WebauthnSetupForm * Add attestation validation error to attestation_object More appropriate than `name`
* LG-13570 we were parsing JSON as JSON and that was bad * LG-13570 lint corrections changelog: Bug Fixes, Reports, Resolve double-parsing JSON in Dropoff report (LG-13570)
* Force side effects to happen via act() in specs changelog: Internal, Source code, Update code to match React conventions
* clean up deprecated width, use USWDS class * clean up deprecated width * changelog: Internal, Enhanced IPP, Addressed additional code comments (clean up depricated width on td, round image width * Remove extra forward arrow * Add png images for Ready To Verify email
**Why**: Without a "| limit 10000", the script will not be able to detect missing data, so it won't return the expected results * lint: move regex with interpolation into a constant * Add missing limit caught by specs changelog: Internal, Scripts, Update Cloudwatch querying client
* Treat yarn.lock as a diffable file * Treat knapsack_rspec_report.json as diffable file changelog: Internal, Source code, Update .gitattributes for yarn.lock --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
- yarn upgrade jsdom - yarn upgrade webpack-dev-server See: https://github.com/18F/identity-idp/security/dependabot/77 * yarn-deduplicate * Commit lockfile changes * Update build-sass/cli.js to fix new typecheck error changelog: Internal, Source code, Upgrade dependencies to fix security vulnerabilities
* Proof-of-concept: reCAPTCHA at sign-in * Configure review apps for sign-in reCAPTCHA * Shift device validation to SignInRecaptchaForm * Add feature short-circuiting on disabled reCAPTCHA * Accept button_options as optional property on captcha component * Remove unnecessary value override Previously needed since recaptcha_token wasn't a method on SignInRecaptchaForm, but the method was added in ede24b278b * Implement reCAPTCHA exemption via score_threshold Base classes manage exemption already using score threshold, so initialize score threshold based on expected sign-in exemption cases * Log reCAPTCHA result with sign-in attempt * Update selector to look for specific SP banner text * Add changelog changelog: Upcoming Features, Spam Mitigation, Add reCAPTCHA at sign-in behind feature flag * Render CAPTCHA submit conditionally by feature flag Not strictly necessary, but safer, and avoids loading extra resources while disabled * Fix captcha validation with mock validator Move short-circuit to score_threshold logic * Fix renamed phone_recaptcha_mock_validator See: #10772 (comment) Co-Authored-By: Malick Diarra <malick.diarra@gsa.gov> * Refactor to simplify captcha validation logging Revert to behavior more similar to how it works on main --------- Co-authored-by: Malick Diarra <malick.diarra@gsa.gov>
* Un-DRY GpoMail class a tad bit [skip changelog]
* Add site_name OpenGraph metadata changelog: Internal, Layout, Add OpenGraph metadata for site name * Add regression spec for OpenGraph tag
* Add yarn-deduplicate and lint to enforce it * Update docs * commit yarn.lock changes changelog: Internal, Source code, Enforce usage of yarn-deduplicate via lint --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
zachmargolis
approved these changes
Jun 25, 2024
mitchellhenke
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal
Upcoming Features