Standardize form validation for WebauthnSetupForm#10782
Merged
Conversation
mitchellhenke
approved these changes
Jun 10, 2024
changelog: Internal, WebAuthn, Standardize form validation for WebauthnSetupForm
More appropriate than `name`
04bbfcf to
3a19e1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Refactors
WebauthnSetupFormto validate parameters in a standardized manner:submitaccepts a single hash of parametersActiveModel::Modelvalidation methods (validates, etc.) to add errorsActiveModel::Model#valid?aloneThis originally started with a desire to replace the ad hoc
webauthn_setup_submittedwithmulti_factor_auth_setup, which then led to the realization that setups can happen through multiple pathways and forms (WebauthnSetupFormandWebauthnVisitForm). The changes here are intended to standardize behaviors inWebauthnSetupFormto help prepare for the next step of mergingWebauthnSetupFormandWebauthnVisitForm.📜 Testing Plan
Verify there are no regressions in the setup of a Face or Touch Unlock or Security Key MFA method.
Verify that tests pass: