Replace Alert component "other" as default style#10779
Merged
Conversation
aduth
commented
Jun 7, 2024
nickttng
approved these changes
Jun 7, 2024
zachmargolis
approved these changes
Jun 13, 2024
changelog: Internal, UI Components, Replace Alert component "other" as default style
88a7d08 to
001f103
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
AlertComponentto replace the explicit:othervariant to be used as the default, instead of:info.For additional context, refer to 18F/identity-design-system#449
Stylistically, there is visual difference in the previous
type: :othercompared with the new default appearance, since we never actually applied theusa-alert--otherclass. This works to our benefit, since there's effectively no change as a result of the upcoming design system release, and no logic changes needed to remove the application of ausa-alert--otherclass.As part of these changes, I searched code for existing usage of
AlertComponentnot specifyingtypewith the assumption of rendering an:infoalert banner and passed an explicittype: :infoto avoid regressions.📜 Testing Plan
Verify there are no regressions in the impacted code previously assuming default
:infoalert type.Verify the "Other" type styles are now shown as the "Default" (
type: nil) styles in the component preview:👀 Screenshots