Conversation
[skip changelog]
matthinz
approved these changes
Jun 21, 2024
jmhooper
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Indirectly related to 13421
🛠 Summary of changes
In my main story I'm adding a GpoVerifyByMailPolicy class. We want to eventually fold the GpoMail class into it.
As part of that, we noticed that
phone_step_attemptsin particular was sort of out of place in a class called GpoMail.Because these are both small and simple, I just moved
hours_since_first_letterinto the two classes using it, and inlined what was formerlyphone_step_attempts. It's ultimately a little less code.