LG-13570 we were parsing JSON as JSON and that was bad

[ajfarkas]

🎫 Ticket

Link to the relevant ticket:
LG-13570

🛠 Summary of changes

We were seeing the error: no implicit conversion of Array into String on the dropoff report.
This was because we're implicitly converting our configs to their described type in identity_config.rb, and then trying to parse that JSON with JSON.parse in drop_off_report.rb.

This PR comments our code and removes the offending parse.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Updated tests catch double-parsing
• Report should go out as planned.

Thanks to @h-m-m and @nprimak for working on this bug.

[zachmargolis]

probably easier to have this as a ruby literal than managing a string

Suggested change

	JSON.parse'[{"emails":["ursula@example.com"],
	"issuers":["urn:gov:gsa:openidconnect.profiles:sp:sso:agency_name:app_name"]}]'
	[
	{
	"emails" => ["ursula@example.com"],
	"issuers" => ["urn:gov:gsa:openidconnect.profiles:sp:sso:agency_name:app_name"],
	},
	]

[ajfarkas]

The purpose of this is to point out that this line is a String in our config, and we auto-parse it to JSON.
The comment above is an important addition.

[zachmargolis]

The config parsing is standard across our app, and intended to abstract away the minutiae of parsing the string values.

But if we really want to parse a string in this spec,, I think that the multi-line string literal here is really hard to parse, it would be much clearer using heredoc syntax and adding in the optional parens:

Suggested change

	JSON.parse'[{"emails":["ursula@example.com"],
	"issuers":["urn:gov:gsa:openidconnect.profiles:sp:sso:agency_name:app_name"]}]'
	JSON.parse(<<~STR)
	[{"emails":["ursula@example.com"],"issuers":["urn:gov:gsa:openidconnect.profiles:sp:sso:agency_name:app_name"]}]
	STR