Skip to content

Render lang attribute for email language preference#10841

Merged
aduth merged 1 commit intomainfrom
aduth-email-lang-of-parts
Jun 21, 2024
Merged

Render lang attribute for email language preference#10841
aduth merged 1 commit intomainfrom
aduth-email-lang-of-parts

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jun 20, 2024

🛠 Summary of changes

Updates account page email language preference to render lang attribute when showing content in a language other than the page's current language, following #10808 and to satisfy WCAG SC 3.1.2 Language of Parts.

Previously: #10808 (review)

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Sign in
  3. On account dashboard, change email language preference to a language other than English (or conversely, change the current page language to a language other than English)
  4. Activate screen reader
  5. Navigate to the text value for current email language preference
  6. Observe that screen reader announces language value in that language

👀 Screenshots

(You may need to unmute video player for audio to play)

Before:

before.mp4

After:

after.mp4

changelog: Bug Fixes, Accessibility, Render email language preference as language of parts
@aduth aduth force-pushed the aduth-email-lang-of-parts branch from 106e8bc to cc5d0e6 Compare June 20, 2024 20:03
@aduth aduth merged commit 98b14d8 into main Jun 21, 2024
@aduth aduth deleted the aduth-email-lang-of-parts branch June 21, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants