Render lang attribute for email language preference#10841
Merged
Conversation
changelog: Bug Fixes, Accessibility, Render email language preference as language of parts
106e8bc to
cc5d0e6
Compare
mitchellhenke
approved these changes
Jun 20, 2024
juliasolorzano
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates account page email language preference to render
langattribute when showing content in a language other than the page's current language, following #10808 and to satisfy WCAG SC 3.1.2 Language of Parts.Previously: #10808 (review)
📜 Testing Plan
👀 Screenshots
(You may need to unmute video player for audio to play)
Before:
before.mp4
After:
after.mp4