Merged
Conversation
changelog: Internal, Source code, Update .gitattributes for yarn.lock
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
n1zyy
approved these changes
Jun 21, 2024
Contributor
n1zyy
left a comment
There was a problem hiding this comment.
I tripped over this trying to look at your PR, too: #10854 (comment)
The spirit of .gitattributes is great, but I agree that these should be made to show diffs.
mitchellhenke
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10518 we added
.gitattributesHowever, treating
yarn.lockas a binary file has challenged my local workflow, so I can't add files incrementally withgit add --patch(git add -p), they get skippedThis came up when I was working on #10854
Before
After
(I can update
yarn.lockviagit add -p)