Conversation
| end | ||
| end | ||
|
|
||
| def inline? |
There was a problem hiding this comment.
if we're following through with this we should also update the logic in http_push.rb and remove the risc_notifications_active_job_enabled feature flag as well
There was a problem hiding this comment.
Right, I saw that when the tests failed on CI. Looking into it.
vrajmohan
force-pushed
the
remove-inline-risc-job
branch
4 times, most recently
from
c95eeea to
f787e33
Compare
There was a problem hiding this comment.
let's inline the job_arguments hash here
There was a problem hiding this comment.
this was the last usage of this feature flag, so now let's fully remove it everywhere by taking it out of application.yml.default and identity_config.rb
There was a problem hiding this comment.
This was what I intended with my commit comment -> How -> 3rd bullet. Did you mean something else?
There was a problem hiding this comment.
Feature flags are safe to remove in the codebase in the same PR that stop using them, so no need for a second PR
There was a problem hiding this comment.
Got it, I should have remembered that.
**Why**: RISC notifications are delivered through an ActiveJob; inline invocation is no longer used. **How**: 1. Remove references to risc_notifications_active_job_enabled in code and assume it to be true 2. Refactor tests to assert that RiscDeliveryJob is scheduled with the correct arguments changelog: Internal, RISC, Remove obsolete code
vrajmohan
force-pushed
the
remove-inline-risc-job
branch
from
4ae5546 to
e68aea5
Compare
2 participants
No description provided.