Convert observable property functions to a React Hook#10838
Merged
zachmargolis merged 2 commits intomainfrom Jun 21, 2024
Merged
Convert observable property functions to a React Hook#10838zachmargolis merged 2 commits intomainfrom
zachmargolis merged 2 commits intomainfrom
Conversation
changelog: Internal, Source code, Update code to match React conventions
zachmargolis
changed the title
aduth
reviewed
Jun 20, 2024
Contributor
Author
Got it working in 32f7b2a via |
Contributor
Author
|
Verified that the SDK seems to work properly by going through IDV on mobile using the review aopp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporating PR feedback: #10809 (comment)
This is in draft mode because the
acuant-capture-canvas-spec.jsxis failing, I think there's some out-of-order event subscription happening