Merged
Conversation
changelog: Internal, Documentation, Add documentation for missing piv_cac_login arguments
* changelog: User-Facing Improvements, Doc Auth, When selfie capture is enabled, only allow images through SDK * Prevent upload if selfie capture is enabled * Prevent native camera event if selfie enabled The "IdV: Native camera forced after failed attempts" event was firing even though the previous commit disallows file upload and use of the native camera. This commit prevents this event from firing. * Mv SelfieCaptureContext above FailedCaptureAttempts [See this Slack thread for details](https://gsa-tts.slack.com/archives/C05HSH9RQ57/p1709940634853369?thread_ts=1709857278.599209&cid=C05HSH9RQ57). * Add isSelfieDesktopMode to selfieCaptureContext isSelfieDesktopMode is needed in the next commit to allow upload when isSelfieDesktopMode is true. * Allow upload when desktopMode enabled Without looking at this value, we won't be able to upload yml files if desktop test mode and selfie are both enabled.
…10228) * Remove auto-closing behavior * Change the way hiding the button works to function with the focustrap * Remove spinner fullscreen * Revise test * changelog: Internal, In-Person Proofing, Fix selfie screen reader problem by adding FullScreen component * Add role=img * Fix lint * Restore the hint text by moving outside the container * Remove unnessecary image role from gifs * Lint fix * Make the "X" close button functional * Remove request close function - this breaks the selfie capture experience * Revert changes to fullscreen * Add close button to avoid getting stuck if something goes wrong * Fix lint problem * Fix button text
…#10222) Jack found a sneaky bug, where the UX was correct, but the profile would not be able to be reactivated because validation prevents an in_person_verification_pending profile from activation. Now fixed! changelog: Bug Fixes, IPP, Mark fraudulent profiles as not pending IPP Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
changelog: Internal, Reporting, Bug fix LG-99 unique user report
* changelog: Bug Fixes, OIDC protocol, Returns correct x509:presented attribute type
* user has active profile and non biometric request will not redirect * add user#active_legacy_profile user#active_legacy_profile checks for active profiles that do not have the biometric selfie requirement * add changelog changelog: Internal, IdV biometrics, allow active user to sign into non biometric sp * fix tests and logic * add check for verified attributes in test * created PendingProfilePolicy PendingProfilePolicy is a class used to determine if a user has a legacy or biometric pending profile and if the service provider requests biometrics or not Co-authored-by: Doug Price <douglas.price@gsa.gov> * remove user#active_legacy_profile * use PendingProfilePolicy in oidc authorize controller * useable -> usable * add test for vots in auth controller --------- Co-authored-by: Doug Price <douglas.price@gsa.gov>
* change hint text to sentence case * make selfie hint text colors match id capture hint text colors * change how feedback color is represented in scss * changelog: User-Facing Improvements, DocAuth, make selfie hint text styling match id capture hint text styling * fix styling to use color utility function * merge document-capture-selfie feedback styling
* changelog: Internal, In-Person Proofing, Update a comment about the acuant globals --------- Co-authored-by: Brittany Greaner <brittany.greaner@gsa.gov>
* LG-12672: UI update for hybrid handoff page. * LG-12672: remove IPP option since it's for another ticket. changelog: User-Facing Improvements, Doc Auth, Selfie flavor of handoff page. * LG-12672: test for erb template. * LG-12672: use i18n text. * LG-12672: fix test. * LG-12672: fix test.
* Make revisions on MFA selection screen changelog: User-Facing Improvements, authentication, align language for security key * Add text for security key on account page * replace hardcoded app name * interpolate app name * lintfix * tweaks to margins * address PR comments: static text and HTML classes
[skip changelog]
…10256) * User-Facing Improvements, phishing-resistant MFAs, improve security key error messaging * changelog: User-Facing Improvements, phishing-resistant MFAs, improve security key error messaging
changelog: Bug Fixes, PIV/CAC, Consistently clear PIV session detail after deletion
* Update track_event call not to use .exactly(0).times have_logged_event doesn't support this, so we shouldn't use it here. Also, it seems like all the event detail isn't required here--this event is only logged if the form submission succeeds * Update not_to receive(:track_event) to not_to have_logged_event * Update receive(:track_event) to have_logged_event * [skip changelog]
Bumps [phonelib](https://github.com/daddyz/phonelib) from 0.8.7 to 0.8.8. - [Release notes](https://github.com/daddyz/phonelib/releases) - [Changelog](https://github.com/daddyz/phonelib/blob/master/CHANGELOG.md) - [Commits](daddyz/phonelib@v0.8.7...v0.8.8) --- updated-dependencies: - dependency-name: phonelib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There are a few track_event calls where the **extra arg is not passed through. This commit updates those to pass **extra. [skip changelog]
* in progress changes maybe revert * update helper to accept tmx status for ssn step * new tmx only spec * Add new method and allow arguments * Utilize new arguments for ssn step * begin specs * initial specs complete * added in test for cancel ipp option * New spec for failed ipp enrollment * lintage * adding in action_account emulation * move tmx related specs to new file * move tmx specs to new file * lintereedoo * add pass ipp fail tmx case * use one before statement * fix lint issue and update descriptions * changelog: Internal, TMX, tests * comment out failing test to be completed in a future ticket * comment out another failing test * Fixes trivial rubocop nit * ensure email count is updated after tmx review --------- Co-authored-by: svalexander <shannon.alexander-navarro@gsa.gov> Co-authored-by: Matt Wagner <mattwagner@navapbc.com>
…0244) * Add missing analytics event * Revert change used for diagnosing * changelog: Bug Fixes, fix selfie logging * Fix order * Rename event to match our new naming convention * Remove unnessecary 'added' event * changelog: Bug Fixes, In Person Proofing, Add a missing log method to analytics
matthinz
requested review from
JackRyan1989,
Sgtpluck,
aduth,
charleyf,
eileen-nava,
jmdembe,
n1zyy,
night-jellyfish,
theabrad and
zachmargolis
zachmargolis
approved these changes
Mar 19, 2024
jmdembe
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Upcoming Features
Internal