Clean PIV session detail after deletion (2)#10238
Merged
Conversation
changelog: Bug Fixes, PIV/CAC, Consistently clear PIV session detail after deletion
aduth
changed the title
jmdembe
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Adds missing PIV behavior for deleted PIV, expected to remove cached
user_sessiondetail. This carries forward from the original implementation preceding #9861, removed in #10218.identity-idp/app/controllers/users/piv_cac_authentication_setup_controller.rb
Line 39 in b456d85
This is the same as #10220, but applied to the no-JS fallback controller (
Users::PivCacController) in addition to the JavaScript API controller (Api::Internal::TwoFactorAuthentication::PivCacController).📜 Testing Plan