Skip to content

LG-12606 Security Key Error flow content and workflow improvements#10256

Merged
kevinsmaster5 merged 2 commits intomainfrom
kmas-lg-12606-security-key-error-flow
Mar 18, 2024
Merged

LG-12606 Security Key Error flow content and workflow improvements#10256
kevinsmaster5 merged 2 commits intomainfrom
kmas-lg-12606-security-key-error-flow

Conversation

@kevinsmaster5
Copy link
Copy Markdown
Contributor

🎫 Ticket

LG-12606

🛠 Summary of changes

Revise translated text for webauthn_setup error messages.

👀 Screenshots

Already registered key
en-alreadyregistered
es-alreadyregistered
fr-alreadyregistered
General error
en-generalerror
es-generalerror
fr-generalerror
Not supported
en-notsupported
es-notsupported
fr-notsupported
Unique name
en-notunique
es-notunique
fr-notunique

Copy link
Copy Markdown
Contributor Author

@kevinsmaster5 kevinsmaster5 Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspect this was a bug disguised by the previous sameness between webauthn_setup.unique and webauthn_platform_setup.unique.
A nickname doesn't get added in the webauthn_platform setup workflow.

@kevinsmaster5 kevinsmaster5 force-pushed the kmas-lg-12606-security-key-error-flow branch from 1cb76f6 to 4abe8d3 Compare March 18, 2024 13:15
@kevinsmaster5 kevinsmaster5 marked this pull request as ready for review March 18, 2024 13:55
@kevinsmaster5 kevinsmaster5 requested a review from a team March 18, 2024 14:04
@kevinsmaster5 kevinsmaster5 merged commit 6ae88ce into main Mar 18, 2024
@kevinsmaster5 kevinsmaster5 deleted the kmas-lg-12606-security-key-error-flow branch March 18, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants