Skip to content

LG-12678 x509:presented attribute type#10239

Merged
Sgtpluck merged 4 commits intomainfrom
dmm/LG-12678/fix-x509_presented-bug
Mar 15, 2024
Merged

LG-12678 x509:presented attribute type#10239
Sgtpluck merged 4 commits intomainfrom
dmm/LG-12678/fix-x509_presented-bug

Conversation

@Sgtpluck
Copy link
Copy Markdown
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-12678

🛠 Summary of changes

  • Adds more complete test
  • Updates x509:presented attribute to return boolean string, as indicated in the documentation

@Sgtpluck Sgtpluck requested review from a team and aduth March 13, 2024 13:49
@Sgtpluck Sgtpluck force-pushed the dmm/LG-12678/fix-x509_presented-bug branch from ea9e73f to 85982d4 Compare March 14, 2024 17:31
end
end
end
end
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm this looks like a mistake maybe from my rebase, will investigate

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fixed whew

@Sgtpluck Sgtpluck force-pushed the dmm/LG-12678/fix-x509_presented-bug branch from 7b60adc to cb4d912 Compare March 15, 2024 13:47
@Sgtpluck Sgtpluck force-pushed the dmm/LG-12678/fix-x509_presented-bug branch from cb4d912 to 59fd243 Compare March 15, 2024 13:55
@Sgtpluck Sgtpluck merged commit c5ff10f into main Mar 15, 2024
@Sgtpluck Sgtpluck deleted the dmm/LG-12678/fix-x509_presented-bug branch March 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants