LG-12678 Updates nil return value to false#10259
Merged
Conversation
[skip changelog]
ajfarkas
approved these changes
Mar 18, 2024
Contributor
ajfarkas
left a comment
ajfarkas
left a comment
There was a problem hiding this comment.
Like these straightfoward changes.
Jeremy1026
approved these changes
Mar 18, 2024
mitchellhenke
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 TicketLink to the relevant ticket:
LG-12678
🛠 Summary of changes
We updated the documented values to boolean -- so returning
falsewhen piv/cac is not used makes more sense, rather than anilreturn. (Boolean is more straightforward, and easier for partners using typed languages)