Fix Network Error in Dev by Adding missing selfie analytics event

[charleyf]

🛠 Summary of changes

I'm looking into some black screen on open problems that selfie is happening. The first thing that caught my eye was a logger error. It's unrelated to the black screen, but this PR fixes that error.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• On main get to the front/back/selfie upload page.
• Open Safari and use the "Develop" menu to view the console for the page you have open on your iPhone.
• Open to the "network" tab in safari so you can see the requests your iPHone is making.
• Click the selfie box.
• Note that there's a network request from logger that fails with a 400.
• Switch to this branch: charley/fix-selfie-log
• Repeat the steps above, there will now be no failed network requests from logger.

[night-jellyfish]

Is captureAttempts easy to add in?

[aduth]

Is captureAttempts easy to add in?

👍 I'd hope we could add all of the properties here we're expecting to be logged.

[aduth]

For new analytics events, I'd wonder if it's worth trying to address some of what's being identified in these linters, i.e. naming the event properties with snake case. I suspect it might be made difficult by multiple events sharing the same common payload, but it seems like we will want to address that at some point anyways.

[aduth]

Is captureAttempts easy to add in?

👍 I'd hope we could add all of the properties here we're expecting to be logged.

[charleyf]

I'm going to leave a bit of time for comments, but my plan is to merge this shortly (~noon/1pm) as is and revisit in LG-12178.

I would prefer to add the correct properties to this event, remove the rubocop:disable and generally put more time into this, but I don't think that's where I should be putting my time right now.

Reasoning:

• I put this PR up because I want to remove a console error I'm seeing in dev that's making the black screen issue (recent slack) more confusing.
• This event the way I implemented it matches the existing events idv_front_image_clicked and idv_back_image_clicked.
• The ticket here: https://cm-jira.usa.gov/browse/LG-12178
  • Contains the various improvements we want to make. I suspect we're going to need to make that improvement to all three of the clicked events: idv_front_image_clicked, idv_back_image_clicked, and idv_selfie_image_clicked`.
  • I've gone and updated that ticket with a link to this PR and also some notes about what we've discussed here.