LG-12597: Make revisions on MFA selection screen#10249
Merged
Conversation
changelog: User-Facing Improvements, authentication, align language for security key
aduth
changed the title
kevinsmaster5
approved these changes
Mar 14, 2024
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
It looks good to me. 👍
Tested locally also.
aduth
reviewed
Mar 14, 2024
Comment on lines
+15
to
+17
| <p class="margin-bottom-0"><%= @presenter.intro %></p> | ||
|
|
||
| <p class="margin-top-2"><%= @presenter.recommendation %></p> |
Contributor
There was a problem hiding this comment.
If this recommendationi is static text, I think we can just embed it directly here, to avoid unnecessary indirection? The value I see in presenter methods is to abstract some conditional or complex logic.
Also, could we collapse the margins if the default for a paragraph is to have a bottom margin and we don't need the margin-bottom-0 anymore?
Suggested change
| <p class="margin-bottom-0"><%= @presenter.intro %></p> | |
| <p class="margin-top-2"><%= @presenter.recommendation %></p> | |
| <p class="margin-bottom-2"><%= @presenter.intro %></p> | |
| <p><%= t('mfa.recommendation') %></p> |
Alternatively, we could omit the class altogether, since margin-bottom-2 is equivalent to the default bottom margin for a paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12597
🛠 Summary of changes
This PR aligns language regarding security keys on both the "My Account" and "MFA Selection" page
👀 Screenshots
Figma file
Authentication options text
Security Key Option
My Account Page
|