LG-12672: handoff page update when selfie required#10251
Merged
dawei-nava merged 6 commits intomainfrom Mar 15, 2024
Merged
Conversation
dawei-nava
requested review from
amirbey,
charleyf,
kellular and
night-jellyfish
dawei-nava
changed the title
changelog: User-Facing Improvements, Doc Auth, Selfie flavor of handoff page.
dawei-nava
force-pushed
the
dwang/LG-12672_handoff_update
branch
from
cf8ccf8 to
be2c925
Compare
kellular
approved these changes
Mar 14, 2024
kellular
left a comment
kellular
left a comment
There was a problem hiding this comment.
This looks good from a UX perspective!
eileen-nava
approved these changes
Mar 15, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
I manually checked these scenarios:
- desktop, selfie enabled but not required: ✅
- desktop, selfie enabled and required: ✅
Looks good to me, approved.
| end | ||
| end | ||
|
|
||
| context 'on a desktop device and selfie is allowed' do |
Contributor
There was a problem hiding this comment.
Good test coverage. 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12672
🛠 Summary of changes
UI update for hybrid handoff page when selfie is required.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
On desktop , with
doc_auth_selfie_desktop_test_mode: false.👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
After: