LG-12577 Allow active profile to sign in to non-biometric SP#10211
LG-12577 Allow active profile to sign in to non-biometric SP#10211
Conversation
user#active_legacy_profile checks for active profiles that do not have the biometric selfie requirement
changelog: Internal, IdV biometrics, allow active user to sign into non biometric sp
spec/models/user_spec.rb
Outdated
| describe '#active_legacy_profile' do | ||
| it 'returns the active_legacy_profile' do | ||
| user = create(:user, :fully_registered) | ||
| profile1 = create(:profile, :active, :verified, user: user, idv_level: :legacy_unsupervised) |
There was a problem hiding this comment.
Can we get a version of this test that does the same check for in_person and legacy_in_person just so we have the other possible values for idv_level covered
spec/controllers/openid_connect/authorization_controller_spec.rb
Outdated
Show resolved
Hide resolved
PendingProfilePolicy is a class used to determine if a user has a legacy or biometric pending profile and if the service provider requests biometrics or not Co-authored-by: Doug Price <douglas.price@gsa.gov>
| ) | ||
| end | ||
|
|
||
| def user_has_useable_pending_profile? |
There was a problem hiding this comment.
TIL "useable" can be considered a valid spelling, but from this resource it seems without the "e" is more common in American English:
| def user_has_useable_pending_profile? | |
| def user_has_usable_pending_profile? |
There was a problem hiding this comment.
"The addition of the “e” in “useable” is considered more common in British English and Europe. "
Oi bruv I was just using the Bri'ish spelling innit. I'll rename it.
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
LGTM, thank you!
I am wondering if eventually we can remove VerifyProfileConcern or move user_has_usable_pending_profile? in there, but that can wait for now.
We could probably move that method into the VerifyProfileConcern. I'll look into it while I work on the SAML implementation. |
3 participants
🎫 Ticket
LG-12577
🛠 Summary of changes
If a user has an active non-biometric profile and a pending biometric profile, when they sign into a SP that does not require biometrics they will be not be redirected to the SP with their non-biometric attributes.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.