Merged
Conversation
Add a comment explaining the use of "P6" for AAMVA requests. [skip changelog]
A previous change introduced a temporary fix to avoid a 50/50 state issue in the SAML controller (ref: #10141). That was intended to be temporary. Once it is deployed and stable the code can be removed. This change removes that code. [skip changelog]
A previous change (ref: #10091) stopped reading from `sp_session[:ial]` and started using the result from the `AuthnContextResolver` instead. This change follows up by removing writes to the `ial` property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
A previous change (ref: #10127) stopped reading from `sp_session[:ialmax]` and started using the result from the `AuthnContextResolver` instead. This change follows up by removing writes to the `ialmax` property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.56 to 1.10.57. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.56...v1.10.57) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#10119) * refer to new methods and simplify code to handle redirection only when ipp passed * changelog: User-Facing Improvements, In-Person Proofing, only redirect when user has passed ipp * Add in nil check to allow redirection when enrollment has no status * add updates to view and spec for view
* LG-12265: Stop reading from sp_session[:piv_cac_requested] In a previous commit the `resolved_authn_context_result` was introduced to return a `Vot::Parser::Result` object that described the requirements for the current SP request considering SP default options. This is intended to be used to replace the keys in the `sp_session` that serve this purpose including the `piv_cac_requested` key. This commit replaces places where the `sp_session[:piv_cac_requested]` value is read with new reads to the `resolved_authn_context_result`. [skip changelog] * Remove misspelled and unnecessary property in sp_session
changelog: Internal, Dependencies, Update rack to address security vulnerabilities
changelog: Internal, Scripts, Fix require in email-deliveries script
changelog: Internal, Configuration, Remove set_remember_device_session_expiration config
…code (#10148) * fix mock proofer to acknowledge selfie status when determining success [skip changelog] * parse errors when attention with barcode * refactor failed_file_data * refactore failed_file_data
* provide imageAnalyticsPayload for selfie capture changelog: Internal, Document Authentication, Selfie image provides metadata upon submission to image uploader * make width, height and fingerprint optional
A previous change (ref: #10129) stopped reading from `sp_session[:ial2]` and started using the result from the `AuthnContextResolver` instead. This change follows up by removing writes to the `ial2` property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
… key flash (#10122) Prior to this commit there were 2 cases where a personal key was showed to a user in a flash message: - When the user resets their password and recovers their PII with a personal key - When the user changes their password from account screen In both cases the user had to have an identity proofed account for the flash to appear. The flash had some issues. It was a distinct experience from the typical personal key issuance. The flash was hard to miss and did not include the features we build to ensure users save their personal key. This commit removes the flash message and redirects the user to the personal key screen when they need to be presented with a personal key in all cases. changelog: User-Facing Improvements, Personal key, The personal key issuance was improved.
…hing_resistant_requested] and started using the result from the AuthnContextResolver instead. (#10140) This change follows up by removing writes to the phishing_resistant_requested property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
[skip changelog] As someone who is fairly new to TS, I found it difficult to understand as I was trying to pass values between a JSX and a TSX file. I decided to timebox converting this file to TS to see if that would make my other work easier. It was fairly straightforward (I think). --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* add changelog changelog: Internal, IdV, write acr_values and vtr to identites table * add vot function to identity token * id_token_builder sends correct acr and vtr values * add changelog changelog: Internal, IdV, Add vot to identity token * fix identity vot and acr names * acr value only has IAL values within * hide vot behind feature flag * store vtm in identity config * fixup with config * add check to not allow vtm if vot is nil * revamp acr method to return correct ial acr values
jmhooper
approved these changes
Feb 27, 2024
mdiarra3
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal