LG-12261 Stop reading from sp_session[:ial]#10091
Merged
Conversation
Comment on lines
66
to
72
Contributor
There was a problem hiding this comment.
maybe idea for future us would be to migrate this to be an enum column so we can name these?
Contributor
Author
There was a problem hiding this comment.
We have another story for sending the VoT back to the partner. @theabrad is working on it. For that we'll likely need to add the acr_values and vtr to the identity column and start reading from those instead of the ial and aal columns. Once we do that we can remove this portion entirely.
jmhooper
force-pushed
the
jmhooper-remove-sp-session-ial
branch
2 times, most recently
from
216fdaf to
1841396
Compare
In a previous commit the `resolved_authn_context_result` was introduced to return a `Vot::Parser::Result` object that described the requirements for the current SP request considering SP default options. This is intended to be used to replace the keys in the `sp_session` that serve this purpose including the `ial` key. This commit replaces places where the `sp_session[:ial]` value is read with new reads to the `resolved_authn_context_result`. [skip changelog]
jmhooper
force-pushed
the
jmhooper-remove-sp-session-ial
branch
from
83900f9 to
1b12fee
Compare
theabrad
approved these changes
Feb 22, 2024
jmhooper
added a commit
that referenced
this pull request
Feb 22, 2024
A previous change (ref: #10091) stopped reading from `sp_session[:ial]` and started using the result from the `AuthnContextResolver` instead. This change follows up by removing writes to the `ial` property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Feb 23, 2024
A previous change (ref: #10091) stopped reading from `sp_session[:ial]` and started using the result from the `AuthnContextResolver` instead. This change follows up by removing writes to the `ial` property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous commit the
resolved_authn_context_resultwas introduced to return aVot::Parser::Resultobject that described the requirements for the current SP request considering SP default options. This is intended to be used to replace the keys in thesp_sessionthat serve this purpose including theialkey.This commit replaces places where the
sp_session[:ial]value is read with new reads to theresolved_authn_context_result.