Setup for LG-12307: Doc Side Acuant to TS#10155
Merged
night-jellyfish merged 2 commits intomainfrom Feb 26, 2024
Merged
Conversation
aduth
approved these changes
Feb 26, 2024
app/javascript/packages/document-capture/components/document-side-acuant-capture.tsx
Outdated
Show resolved
Hide resolved
night-jellyfish
force-pushed
the
brittany/lg-12307-setup-js-to-ts
branch
2 times, most recently
from
62aa518 to
6b7b2f7
Compare
[skip changelog] As someone who is fairly new to TS, I found it difficult to understand as I was trying to pass values between a JSX and a TSX file. I decided to timebox converting this file to TS to see if that would make my other work easier. It was fairly straightforward (I think).
…ide-acuant-capture.tsx Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
night-jellyfish
force-pushed
the
brittany/lg-12307-setup-js-to-ts
branch
from
6b7b2f7 to
dc4e8da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Part of LG-12307
🛠 Summary of changes
As someone who is fairly new to TS, when working on the referenced ticket, I found it difficult to understand the code as I was trying to pass values between a JSX and a TSX file.
I decided to timebox converting this file to TS to see if that would make my other work easier. It was fairly straightforward (I think). I thought it'd be easier to review as its own PR.