LG-12265: Stop reading from sp_session[:piv_cac_requested]#10153
Merged
LG-12265: Stop reading from sp_session[:piv_cac_requested]#10153
Conversation
In a previous commit the `resolved_authn_context_result` was introduced to return a `Vot::Parser::Result` object that described the requirements for the current SP request considering SP default options. This is intended to be used to replace the keys in the `sp_session` that serve this purpose including the `piv_cac_requested` key. This commit replaces places where the `sp_session[:piv_cac_requested]` value is read with new reads to the `resolved_authn_context_result`. [skip changelog]
matthinz
reviewed
Feb 23, 2024
| stub_sign_in(user) | ||
| controller.session[:sp] = { phishing_resistant_requeste: true, piv_cac_requested: true } | ||
| controller.session[:sp] = { | ||
| phishing_resistant_requeste: true, |
Contributor
There was a problem hiding this comment.
I see that this was like this before, but does this misspelling ("requeste") affect anything?
Contributor
Author
There was a problem hiding this comment.
LOL - removed it and it still passes. Done in 35df66c
matthinz
approved these changes
Feb 23, 2024
jmhooper
pushed a commit
that referenced
this pull request
Feb 27, 2024
A previous change (ref: #10153) stopped reading from sp_session[:piv_cac_requested] and started using the result from the AuthnContextResolver instead. This change follows up by removing writes to the piv_cac_requested property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
jmhooper
pushed a commit
that referenced
this pull request
Feb 28, 2024
A previous change (ref: #10153) stopped reading from sp_session[:piv_cac_requested] and started using the result from the AuthnContextResolver instead. This change follows up by removing writes to the piv_cac_requested property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12265
🛠 Summary of changes
In a previous commit the
resolved_authn_context_resultwas introduced to return aVot::Parser::Resultobject that described the requirements for the current SP request considering SP default options. This is intended to be used to replace the keys in thesp_sessionthat serve this purpose including thepiv_cac_requestedkey.This commit replaces places where the
sp_session[:piv_cac_requested]value is read with new reads to theresolved_authn_context_result.