Merged
Conversation
jmhooper
force-pushed
the
jmhooper-stop-writing-sp-session-ialmax
branch
from
4d30020 to
2d21ae6
Compare
jmhooper
force-pushed
the
jmhooper-remove-sp-session-ialmax
branch
from
485176e to
407a039
Compare
jmhooper
force-pushed
the
jmhooper-stop-writing-sp-session-ialmax
branch
from
2d21ae6 to
5f3e8da
Compare
jmhooper
force-pushed
the
jmhooper-stop-writing-sp-session-ialmax
branch
from
5f3e8da to
738dcb9
Compare
solipet
approved these changes
Feb 22, 2024
1 task
A previous change (ref: #10127) stopped reading from `sp_session[:ialmax]` and started using the result from the `AuthnContextResolver` instead. This change follows up by removing writes to the `ialmax` property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
jmhooper
force-pushed
the
jmhooper-stop-writing-sp-session-ialmax
branch
from
738dcb9 to
bc56dd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous change (ref: #10127) stopped reading from
sp_session[:ialmax]and started using the result from theAuthnContextResolverinstead.This change follows up by removing writes to the
ialmaxproperty in the SP session. This should not be merged until the change to stop reading is fully merged and deployed.