Merged
Conversation
amirbey
force-pushed
the
amirbey/LG-12427-selfie-metadata
branch
from
fc62e56 to
8196430
Compare
eileen-nava
reviewed
Feb 23, 2024
|
|
||
| function onSelfieCaptureSuccess({ image }: { image: string }) { | ||
| const analyticsPayload: ImageAnalyticsPayload = getAddAttemptAnalyticsPayload({ | ||
| width: null, |
Contributor
There was a problem hiding this comment.
Since width, height, and fingerprint are all null, why not omit those params from getAddAttemptAnalyticsPayload?
Contributor
Author
There was a problem hiding this comment.
Since
width,height, andfingerprintare all null, why not omit those params fromgetAddAttemptAnalyticsPayload?
@eileen-nava - TS will get angry if I don't include them. how about making those fields optional? 🤔
Contributor
There was a problem hiding this comment.
@amirbey I'm good with making the fields optional. 👍🏻
amirbey
force-pushed
the
amirbey/LG-12427-selfie-metadata
branch
from
b729570 to
620fc20
Compare
changelog: Internal, Document Authentication, Selfie image provides metadata upon submission to image uploader
amirbey
force-pushed
the
amirbey/LG-12427-selfie-metadata
branch
from
620fc20 to
5644f35
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12427
🛠 Summary of changes
Create an analyticsImagePayload for selfie when adding image similar to when other images are added by the user.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.