Skip to content

LG-12445: fix mock proofer to evaluate errors when Attention with Barcode#10148

Merged
amirbey merged 4 commits intomainfrom
amirbey/LG-12445-mock-proofer
Feb 26, 2024
Merged

LG-12445: fix mock proofer to evaluate errors when Attention with Barcode#10148
amirbey merged 4 commits intomainfrom
amirbey/LG-12445-mock-proofer

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Feb 23, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12445

🛠 Summary of changes

  • Mock proofer to set the selfie status in DocAuth::Response
  • Mock proofer include selfie status when evaluating success

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Submit yaml with attention barcode and failed selfie
  • Verify Try Again screen is shown

👀 Screenshots

Before: Screenshot 2024-02-23 at 9 32 57 AM
After: Screenshot 2024-02-23 at 3 52 57 PM

@amirbey amirbey self-assigned this Feb 23, 2024
@amirbey amirbey marked this pull request as ready for review February 23, 2024 21:01
@amirbey amirbey changed the title LG-12445: fix mock proofer to acknowledge selfie status when determining success LG-12445: fix mock proofer to evaluate errors when Attention with Barcode Feb 23, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we return failed_data.dig('failed_alert')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ATTENTION_WITH_BARCODE_ALERT seems the default alert if none specified. but here we completely removed it also?

Copy link
Contributor Author

@amirbey amirbey Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawei-nava - default alert? pls elaborate 🤔

prior to this change, if the ATTENTION_WITH_BARCODE existed then we did not generate any errors which we want to maintain but still want the ability to look for other errors. if the mock proofer returns an error for ATTENTION_WITH_BARCODE along with other errors, than it affects the errored message provided back to the FE.

Copy link
Contributor

@dawei-nava dawei-nava Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirbey , Sorry i was referring to DEFAULT_FAILED_ALERTS, which was set when there is no alerts passed in yaml file.

👍 on fixing the issue.

@amirbey amirbey force-pushed the amirbey/LG-12445-mock-proofer branch from 1ed3b60 to 41f61e1 Compare February 26, 2024 17:23
Copy link
Contributor

@dawei-nava dawei-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amirbey
Copy link
Contributor Author

amirbey commented Feb 26, 2024

Screenshot 2024-02-26 at 1 18 00 PM

@amirbey amirbey merged commit a387336 into main Feb 26, 2024
@amirbey amirbey deleted the amirbey/LG-12445-mock-proofer branch February 26, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants