LG-12445: fix mock proofer to evaluate errors when Attention with Barcode#10148
LG-12445: fix mock proofer to evaluate errors when Attention with Barcode#10148
Conversation
There was a problem hiding this comment.
Should we return failed_data.dig('failed_alert')
There was a problem hiding this comment.
The ATTENTION_WITH_BARCODE_ALERT seems the default alert if none specified. but here we completely removed it also?
There was a problem hiding this comment.
@dawei-nava - default alert? pls elaborate 🤔
prior to this change, if the ATTENTION_WITH_BARCODE existed then we did not generate any errors which we want to maintain but still want the ability to look for other errors. if the mock proofer returns an error for ATTENTION_WITH_BARCODE along with other errors, than it affects the errored message provided back to the FE.
There was a problem hiding this comment.
@amirbey , Sorry i was referring to DEFAULT_FAILED_ALERTS, which was set when there is no alerts passed in yaml file.
👍 on fixing the issue.
1ed3b60 to
41f61e1
Compare

🎫 Ticket
Link to the relevant ticket:
LG-12445
🛠 Summary of changes
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
Before:
After: