LG-11625 Redirect to new personal key screen instead of show personal key flash#10122
Merged
LG-11625 Redirect to new personal key screen instead of show personal key flash#10122
Conversation
jmhooper
changed the title
jmhooper
force-pushed
the
jmhooper-remove-personal-key-flash
branch
2 times, most recently
from
a667f2a to
3b18bc9
Compare
… key flash Prior to this commit there were 2 cases where a personal key was showed to a user in a flash message: - When the user resets their password and recovers their PII with a personal key - When the user changes their password from account screen In both cases the user had to have an identity proofed account for the flash to appear. The flash had some issues. It was a distinct experience from the typical personal key issuance. The flash was hard to miss and did not include the features we build to ensure users save their personal key. This commit removes the flash message and redirects the user to the personal key screen when they need to be presented with a personal key in all cases. changelog: User-Facing Improvements, Personal key, The personal key issuance was improved.
jmhooper
force-pushed
the
jmhooper-remove-personal-key-flash
branch
from
3b18bc9 to
e59fce8
Compare
theabrad
approved these changes
Feb 26, 2024
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
LGTM tested locally and works as intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit there were 2 cases where a personal key was shown to a user in a flash message:
In both cases the user had to have an identity proofed account for the flash to appear.
The flash had some issues. It was a distinct experience from the typical personal key issuance. The flash was hard to miss and did not include the features we build to ensure users save their personal key.
This commit removes the flash message and redirects the user to the personal key screen when they need to be presented with a personal key in all cases.
This is what the flash looked like:
The personal key screen looks like this:
