LG-12263 Remove legacy SP-sesison values from completions controller#10127
Merged
LG-12263 Remove legacy SP-sesison values from completions controller#10127
Conversation
zachmargolis
approved these changes
Feb 21, 2024
The `sp_session[:ial2]` and `sp_session[:ialmax]` values are being retired in favor of `resolved_authn_context_result.identity_proofing?` and `resolved_authn_context_result.ialmax?`. This commit does the work of removing these 2 values from `SignUp::CompletionsController`. This removes the last of the references for `sp_session[:ialmax]` so once this is merged and deployed we can stop writing that value. [skip changelog]
jmhooper
force-pushed
the
jmhooper-remove-sp-session-ialmax
branch
from
485176e to
407a039
Compare
jmhooper
added a commit
that referenced
this pull request
Feb 23, 2024
A previous change (ref: #10127) stopped reading from `sp_session[:ialmax]` and started using the result from the `AuthnContextResolver` instead. This change follows up by removing writes to the `ialmax` property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Feb 23, 2024
A previous change (ref: #10127) stopped reading from `sp_session[:ialmax]` and started using the result from the `AuthnContextResolver` instead. This change follows up by removing writes to the `ialmax` property in the SP session. This should not be merged until the change to stop reading is fully merged and deployed. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sp_session[:ial2]andsp_session[:ialmax]values are being retired in favor ofresolved_authn_context_result.identity_proofing?andresolved_authn_context_result.ialmax?. This commit does the work of removing these 2 values fromSignUp::CompletionsController. This removes the last of the references forsp_session[:ialmax]so once this is merged and deployed we can stop writing that value.