Merged
Conversation
Fix format issue to pass pre-push check. Signed-off-by: Long Dai <long0dai@foxmail.com>
Fixing a merge race Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Both HeaderMapImpl::copyFrom() and HeaderUtility::addHeaders() have exactly the same implementation, so remove the latter. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Long Dai <long0dai@foxmail.com>
Risk Level: Medium (some data plane refactors, mostly no-ops for !HTTP/3) Testing: turned up HTTP/3 upstream SDS integration tests Docs Changes: n/a Release Notes: n/a part of #14829 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
…or (#16549) Signed-off-by: rialg <grial@google.com>
Move the inclusion of `socket_option_impl.h` from the header to the source to reduce its exposure. Signed-off-by: James Peach <jpeach@apache.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Long Dai <long0dai@foxmail.com>
According to the GRPC spec https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md The values in the initial metadata can be any valid ASCII character in case of a non binary header type. Risk Level: Low Testing: Unit Tests Docs Changes:N/A Release Notes: Fixing GRPC initial metadata validation for ASCII characters Signed-off-by: Omri Zohar <omriz@google.com>
This makes it possible for a processor to add a body to a request or response that does not have one, or replace the entire body in the response from a header callback without otherwise touching it. Signed-off-by: Gregory Brail <gregbrail@google.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Risk Level: n/a (test only) Testing: yes Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Adding runtime helper protobuf messages for RuntimeUInt32. TODO(WeavingGao): use for Risk Level: Low Testing: Unit Test Docs Changes: N/A Release Notes: N/A part of #16392 Signed-off-by: gaoweiwen <whereisgww@outlook.com>
…ctivate_timers_next_event_loop' (#16221) Commit Message: event: Remove obsolete runtime guard for 'envoy.reloadable_features.activate_timers_next_event_loop' Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: added Platform Specific Features: n/a Fixes #16003 Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Paul Gallagher <pgal@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: James Peach <jpeach@apache.org>
Signed-off-by: Yiming Jin <jinyiming1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]