Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
jmarantz
approved these changes
May 19, 2021
| "source/common/thread:0.0" # Death tests don't report LCOV | ||
| "source/common/matcher:93.3" | ||
| "source/common/quic:88.4" | ||
| "source/common/quic:87.8" |
Contributor
There was a problem hiding this comment.
This target may be flaky.
Code coverage for source/common/quic is lower than limit of 87.8 (87.7)
Contributor
Author
|
Should be addressed by the tests in
#16180
…On Thu, May 20, 2021 at 6:20 PM antonio ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/per_file_coverage.sh
<#16570 (comment)>:
> @@ -18,7 +18,7 @@ declare -a KNOWN_LOW_COVERAGE=(
"source/common/singleton:95.1"
"source/common/thread:0.0" # Death tests don't report LCOV
"source/common/matcher:93.3"
-"source/common/quic:88.4"
+"source/common/quic:87.8"
This target may be flaky.
Code coverage for source/common/quic is lower than limit of 87.8 (87.7)
https://dev.azure.com/cncf/envoy/_build/results?buildId=76243&view=logs&j=5035ce29-be3c-5fcf-dc50-abb6a265f8b1&t=548c3e59-0417-5971-4f1b-f8545005c291&l=17979
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#16570 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AELALPKEDHIN22OKAGPG5ELTOWDKVANCNFSM45ETS3VQ>
.
|
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Fixing a merge race Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending this out in caee https://github.com/envoyproxy/envoy/pull/16569/files fails
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]