event: Remove obsolete runtime guard for 'envoy.reloadable_features.activate_timers_next_event_loop'#16221
Merged
alyssawilk merged 5 commits intoenvoyproxy:mainfrom May 20, 2021
Conversation
…ctivate_timers_next_event_loop`` Signed-off-by: Antonio Vicente <avd@google.com>
alyssawilk
reviewed
Apr 29, 2021
| ------------------------- | ||
| *Normally occurs at the end of the* :ref:`deprecation period <deprecated>` | ||
|
|
||
| * event: removed `envoy.reloadable_features.activate_timers_next_event_loop` runtime guard and legacy code path. |
Contributor
There was a problem hiding this comment.
if you sync to main these need double backticks now.
Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Antonio Vicente <avd@google.com>
alyssawilk
approved these changes
Apr 29, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Yay! Glad this one landed safely :-)
Contributor
|
This flake should be fixed on main. |
…ers_next_event_loop Signed-off-by: Antonio Vicente <avd@google.com>
…ers_next_event_loop Signed-off-by: Antonio Vicente <avd@google.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…ctivate_timers_next_event_loop' (envoyproxy#16221) Commit Message: event: Remove obsolete runtime guard for 'envoy.reloadable_features.activate_timers_next_event_loop' Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: added Platform Specific Features: n/a Fixes envoyproxy#16003 Signed-off-by: Antonio Vicente <avd@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
event: Remove obsolete runtime guard for 'envoy.reloadable_features.activate_timers_next_event_loop'
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: added
Platform Specific Features: n/a
Fixes #16003