examples: unify apt and cleanup unused installation#16519
Merged
phlax merged 4 commits intoenvoyproxy:mainfrom May 19, 2021
Merged
examples: unify apt and cleanup unused installation#16519phlax merged 4 commits intoenvoyproxy:mainfrom
phlax merged 4 commits intoenvoyproxy:mainfrom
Conversation
phlax
reviewed
May 17, 2021
phlax
requested changes
May 17, 2021
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
@daixiang0 can you remove any unecessary installs please
phlax
reviewed
May 17, 2021
phlax
reviewed
May 17, 2021
Member
|
@daixiang0 afaict with can we remove from all other examples |
Member
Author
|
Sure, let's clean up them. |
Signed-off-by: Long Dai <long0dai@foxmail.com>
daixiang0
changed the title
phlax
changed the title
phlax
reviewed
May 17, 2021
phlax
reviewed
May 17, 2021
phlax
reviewed
May 17, 2021
Member
Author
|
@phlax please take a look. |
phlax
reviewed
May 18, 2021
phlax
reviewed
May 18, 2021
phlax
reviewed
May 18, 2021
phlax
reviewed
May 18, 2021
phlax
approved these changes
May 18, 2021
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm once CI agrees - thanks @daixiang0
Member
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
@phlax Hi, could it merged? |
Member
yes - but i would rather main gets fixed first |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Long Dai <long0dai@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Long Dai long0dai@foxmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Unify apt cmd and clean apt cache.
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]