PULL_REQUEST_TEMPLATE.md: hide example#16538
Merged
htuch merged 1 commit intoenvoyproxy:mainfrom May 20, 2021
Merged
Conversation
Signed-off-by: Long Dai <long0dai@foxmail.com>
phlax
approved these changes
May 18, 2021
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm, thanks @daixiang0
tbh - personally i would rather remove this info from the template - its annoying having to remove it and im not sure everyone reads it. A simple link to more info might work better.
this is an improvent anyway i think
Member
Author
|
How about add PR template into developer.md? |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
@phlax Hi, could it merged? |
Member
i would like to get a stamp from @htuch or @mattklein123 before landing this |
htuch
approved these changes
May 20, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Long Dai <long0dai@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Long Dai long0dai@foxmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
It is useless for reviewers or anyone interested in see a PR example in each PR, so hide it.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]