Skip to content

ci: exclude Google Test macros from clang-tidy#16557

Merged
lizan merged 2 commits intoenvoyproxy:mainfrom
jpeach:clang-tidy-exclude-gtest
May 21, 2021
Merged

ci: exclude Google Test macros from clang-tidy#16557
lizan merged 2 commits intoenvoyproxy:mainfrom
jpeach:clang-tidy-exclude-gtest

Conversation

@jpeach
Copy link
Copy Markdown
Contributor

@jpeach jpeach commented May 19, 2021

Commit Message:

Ignore the Google Test functional macros in the clang-tidy configuration.

Additional Description: N/A
Risk Level: Low
Testing: Manually ran ./ci/run_clang_tidy.sh and observed lack of errors due to Google Test macros.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: James Peach <jpeach@apache.org>
@wrowe wrowe requested a review from derekargueta May 19, 2021 21:35
@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented May 19, 2021

@derekargueta could you take a look at this?

@derekargueta
Copy link
Copy Markdown
Member

LGTM, looks like you'll need to merge master to pick up a fix for CI: cc24391

@alyssawilk alyssawilk self-assigned this May 20, 2021
@lizan
Copy link
Copy Markdown
Member

lizan commented May 20, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16557 (comment) was created by @lizan.

see: more, trace.

Signed-off-by: James Peach <jpeach@apache.org>
@lizan lizan merged commit 25574b4 into envoyproxy:main May 21, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Signed-off-by: James Peach <jpeach@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants