quic: reduce socket option header exposure#16541
Merged
wrowe merged 1 commit intoenvoyproxy:mainfrom May 19, 2021
Merged
Conversation
Move the inclusion of `socket_option_impl.h` from the header to the source to reduce its exposure. Signed-off-by: James Peach <jpeach@apache.org>
Contributor
Author
|
The codeql workflow error looks like a problem with the CI tooling: |
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
wrowe
approved these changes
May 18, 2021
Contributor
wrowe
left a comment
wrowe
left a comment
There was a problem hiding this comment.
LGTM including style cleanups/includes ordering. CodeQL-Build failure doesn't intersect with this submission.
Contributor
Author
|
@wrowe the install-deps step failed because the apt indices were corrupt or in a transient state |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Move the inclusion of `socket_option_impl.h` from the header to the source to reduce its exposure. Signed-off-by: James Peach <jpeach@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
This is a trivial cleanup that moves the inclusion of
socket_option_impl.hfrom the header to the source file to reduce its exposure.Additional Description: None
Risk Level: Low
Testing: bazel tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A