http3: cleaning up TODO#16547
Merged
antoniovicente merged 3 commits intoenvoyproxy:mainfrom May 20, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
antoniovicente
previously approved these changes
May 18, 2021
Contributor
|
Coverage failed since lines were removed and the ratio dropped slightly.
|
Contributor
cc @danzh2010 Actually, it seems that coverage is flaky. There was a similar coverage failure in PR #16549 |
Contributor
Author
|
#16569 should fix coverage |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
danzh2010
previously approved these changes
May 19, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
antoniovicente
approved these changes
May 19, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: low (minor quic refactor)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a