Skip to content

Conversation

@chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Oct 30, 2025

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Format: PR/issue number, ✅ / ❌ rn ✅ / ❌ docs
✅ rn - release note added and verified, or assessed to be not necessary, set to ❌ rn before completion
✅ docs - need for docs assessed and merged, or assessed to be not necessary, set to ❌ docs before completion

29 Oct 2025

30 Oct 2025

31 Oct 2025

1 Nov 2025

2 Nov 2025

03 Nov 2025

04 Nov 2025

05 Nov 2025

06 Nov 2025

@cla-bot cla-bot bot added the cla-signed label Oct 30, 2025
@chenjian2664 chenjian2664 marked this pull request as draft October 30, 2025 01:25
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@trinodb trinodb deleted a comment from sourcery-ai bot Oct 30, 2025

* Update JDK to 25.0.1 ({issue}`27117`)
* Support automatic TLS certificate generation in the `ANNOUNCE` node discovery mode. ({issue}`27030`)
* Fix planning failure of certain queries involving empty VALUES. ({issue}`21506`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the point of view of the user, VALUES cannot be empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasiafi PTAL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the point of view of the user, VALUES cannot be empty.

True. How about "Fix planning failure of certain queries where part of the plan is optimized to empty values."?

Comment on lines 5 to 8
* Support automatic TLS certificate generation in the `ANNOUNCE` node discovery mode. ({issue}`27030`)
* Fix planning failure of certain queries involving empty VALUES. ({issue}`21506`)
* Add support for specifying the location of the Exchange Manager configuration file. ({issue}`26611`)
* Publish query finishing time event listener. ({issue}`27202`)
Copy link
Member

@ebyhr ebyhr Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenjian2664 Could you sort entries by the following rule?

  • New features: Start with Add or Add support for or similar wording
  • Performance improvements: Start with Improve or Improve performance or similar wording
  • Bug fixes: Start with Fix or Prevent or similar wording

https://trino.io/development/process#release-note-guidelines


* Support automatic TLS certificate generation in the `ANNOUNCE` node discovery mode. ({issue}`27030`)
* Add support for specifying the location of the Exchange Manager configuration file. ({issue}`26611`)
* Publish query finishing time event listener. ({issue}`27202`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about "Add support for finishing time in event listener" @raunaqmorarka

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish query finishing time in event listener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants