Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 30, 2025

This driver version was incorrectly shaded and is lacking some of the OpenTelemetry semconv classes.

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Tests:

  • Update the tested_versions filter in run_tests.sh to exclude version 442 alongside existing exclusions.

@cla-bot cla-bot bot added the cla-signed label Oct 30, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extend the compatibility test script to also skip JDBC version 442, aligning the skip logic and comment with existing exclusions for incompatible OpenTelemetry semantics.

File-Level Changes

Change Details Files
Skip JDBC version 442 in compatibility tests
  • Add '
442' to the grep exclusion regex for tested_versions
  • Update the preceding comment to reference skipping version 442

  • Tips and commands

    Interacting with Sourcery

    • Trigger a new review: Comment @sourcery-ai review on the pull request.
    • Continue discussions: Reply directly to Sourcery's review comments.
    • Generate a GitHub issue from a review comment: Ask Sourcery to create an
      issue from a review comment by replying to it. You can also reply to a
      review comment with @sourcery-ai issue to create an issue from it.
    • Generate a pull request title: Write @sourcery-ai anywhere in the pull
      request title to generate a title at any time. You can also comment
      @sourcery-ai title on the pull request to (re-)generate the title at any time.
    • Generate a pull request summary: Write @sourcery-ai summary anywhere in
      the pull request body to generate a PR summary at any time exactly where you
      want it. You can also comment @sourcery-ai summary on the pull request to
      (re-)generate the summary at any time.
    • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
      request to (re-)generate the reviewer's guide at any time.
    • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
      pull request to resolve all Sourcery comments. Useful if you've already
      addressed all the comments and don't want to see them anymore.
    • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
      request to dismiss all existing Sourcery reviews. Especially useful if you
      want to start fresh with a new review - don't forget to comment
      @sourcery-ai review to trigger a new review!

    Customizing Your Experience

    Access your dashboard to:

    • Enable or disable review features such as the Sourcery-generated pull request
      summary, the reviewer's guide, and others.
    • Change the review language.
    • Add, remove or edit custom review instructions.
    • Adjust other review settings.

    Getting Help

    Copy link

    @sourcery-ai sourcery-ai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hey there - I've reviewed your changes and they look great!


    Sourcery is free for open source - if you like our reviews please consider sharing them ✨
    Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

    @wendigo wendigo requested a review from losipiuk October 30, 2025 09:40
    This driver version was incorrectly shaded and is lacking some of the OpenTelemetry
    semconv classes.
    @wendigo wendigo force-pushed the serafin/fix-jdbc-compatibility branch from ee290a4 to 132808c Compare October 30, 2025 10:15
    @wendigo wendigo merged commit deaa4b8 into master Oct 30, 2025
    4 of 6 checks passed
    @wendigo wendigo deleted the serafin/fix-jdbc-compatibility branch October 30, 2025 10:16
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Development

    Successfully merging this pull request may close these issues.

    3 participants